Skip to content

fix(commands): deprecate old Param() aliases properly#1538

Open
shiftinv wants to merge 5 commits into
masterfrom
fix/deprecate-params-aliases
Open

fix(commands): deprecate old Param() aliases properly#1538
shiftinv wants to merge 5 commits into
masterfrom
fix/deprecate-params-aliases

Conversation

@shiftinv

@shiftinv shiftinv commented Jun 4, 2026

Copy link
Copy Markdown
Member

Summary

This deprecates Param()'s desc, conv, autocomp, min_value, and max_value parameter aliases properly with a type-checking and runtime warning. These were superseded all the way back in v2.3, but somehow never got formally deprecated.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running uv run nox -s lint
    • I have type-checked the code by running uv run nox -s pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: deprecation Deprecation of existing features t: bugfix skip news labels Jun 4, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jun 4, 2026

Copy link
Copy Markdown

Documentation build overview

📚 disnake | 🛠️ Build #33456157 | 📁 Comparing 7b5896e against latest (11d8474)

  🔍 Preview build  

51 files changed · ± 51 modified

± Modified

@shiftinv

shiftinv commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

Reconsidering the (proper) deprecation of min_value and max_value here... it might be worth keeping them around as proper aliases, i'll probably revisit this another day

edit: Not deprecating those two would complicate things, and besides, having more than one way of specifying a min/max value seems superfluous anyway.

@shiftinv
shiftinv marked this pull request as draft June 23, 2026 16:43
@shiftinv
shiftinv marked this pull request as ready for review July 5, 2026 18:53
@shiftinv shiftinv removed the skip news label Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t: bugfix t: deprecation Deprecation of existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant